Skip to content

Coalescing for load/store with block ptrs #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
etiotto merged 27 commits into from
Oct 24, 2024
Merged

Coalescing for load/store with block ptrs #2502

etiotto merged 27 commits into from
Oct 24, 2024

Conversation

@etiotto
Copy link
Contributor

@etiotto etiotto commented Oct 16, 2024 •
edited
Loading

This PR improves the coalesceing pass so that it can coalesce loads and stores using block pointers.

@etiotto etiotto self-assigned this Oct 16, 2024
@etiotto etiotto linked an issue Oct 16, 2024 that may be closed by this pull request
Improve performance of tt.load and tt.store for FP8 when converting block ptr to regular ptrs #2374
Closed
etiotto added 10 commits October 17, 2024 14:57
@etiotto
Copy link
Contributor Author

etiotto commented Oct 18, 2024

This PR will be rebased once PR #2514 lands.

@etiotto etiotto marked this pull request as ready for review October 22, 2024 13:27
@etiotto etiotto changed the title [WIP]: Coalescing for load/store with block ptrs Coalescing for load/store with block ptrs Oct 22, 2024
etiotto
etiotto commented Oct 22, 2024
View reviewed changes
whitneywhtsang
whitneywhtsang reviewed Oct 23, 2024
View reviewed changes
@etiotto
Address code review comments
2f97c1a 
Signed-off-by: Tiotto, Ettore <[email protected]>
@etiotto
Fix pre_commit
95f5832 
Signed-off-by: Tiotto, Ettore <[email protected]>
@etiotto etiotto merged commit 90bf600 into main Oct 24, 2024
4 checks passed
@etiotto etiotto deleted the etiotto/coalesce_for_block_ptr branch October 24, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whitneywhtsang whitneywhtsang whitneywhtsang approved these changes

@chengjunlu chengjunlu Awaiting requested review from chengjunlu

@Dewei-Wang-sh Dewei-Wang-sh Awaiting requested review from Dewei-Wang-sh

@leonling-ll leonling-ll Awaiting requested review from leonling-ll

@alexbaden alexbaden Awaiting requested review from alexbaden

Assignees

@etiotto etiotto

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve performance of tt.load and tt.store for FP8 when converting block ptr to regular ptrs

3 participants

@etiotto @whitneywhtsang